Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1alpha1 of the execcredential #108616

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Remove v1alpha1 of the execcredential #108616

merged 2 commits into from
Mar 18, 2022

Conversation

margocrawf
Copy link
Contributor

@margocrawf margocrawf commented Mar 9, 2022 •
edited

What type of PR is this?

/kind api-change
/kind deprecation

What this PR does / why we need it:

This deletes the v1alpha1 version of the ExecCredential for 1.24. The ExecCredential API went GA in 1.22.

Does this PR introduce a user-facing change?

client.authentication.k8s.io/v1alpha1 ExecCredential has been removed. If you are using a client-go credential plugin that relies on the v1alpha1 API please contact the distributor of your plugin for instructions on how to migrate to the v1 API.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

TODO open a docs PR to make sure there are no references to this and to note that the v1alpha1 api has been removed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @margocrawf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 9, 2022
@enj
Copy link
Member

enj commented Mar 9, 2022

/kind cleanup
/ok-to-test
/assign
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 9, 2022
@enj
Copy link
Member

enj commented Mar 9, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 9, 2022
@margocrawf
Copy link
Contributor Author

/kind api-change
/kind deprecation

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Mar 9, 2022
@margocrawf margocrawf changed the title WIP: Remove v1alpha1 of the execcredential Remove v1alpha1 of the execcredential Mar 16, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@margocrawf margocrawf force-pushed the delete-execcredential-v1alpha1 branch from 437565a to 247de72 Compare March 17, 2022 20:15
@margocrawf
Copy link
Contributor Author

/retest

@margocrawf
Remove v1alpha1 of the execcredential
5b690b4 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@margocrawf
Generated code for deleting exec credential v1alpha1 api
38cbe6d 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@margocrawf margocrawf force-pushed the delete-execcredential-v1alpha1 branch from 247de72 to 38cbe6d Compare March 18, 2022 17:18
@enj
Copy link
Member

enj commented Mar 18, 2022

/lgtm

@liggitt can you approve the API removal?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@liggitt
Copy link
Member

liggitt commented Mar 18, 2022

/approve

@liggitt liggitt added this to API review completed, 1.24 in API Reviews Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, margocrawf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@margocrawf
Copy link
Contributor Author

/retest

@margocrawf margocrawf mentioned this pull request Mar 18, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit b9817c8 into kubernetes:master Mar 18, 2022
@liggitt liggitt mentioned this pull request Mar 19, 2022
Merged
@vinayakankugoyal vinayakankugoyal mentioned this pull request Mar 21, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Open
@stevehipwell stevehipwell mentioned this pull request May 4, 2022
Open
2 tasks
@appdog appdog mentioned this pull request May 5, 2022
Closed
@al-cheb al-cheb mentioned this pull request May 5, 2022
Closed
8 tasks
@rabbitfang rabbitfang mentioned this pull request May 13, 2022
Merged
3 tasks
@ConnorJC3 ConnorJC3 mentioned this pull request May 19, 2022
Merged
5 tasks
@jrhouston jrhouston mentioned this pull request Jun 18, 2022
Closed
@rittneje
Copy link

rittneje commented Nov 2, 2022 •
edited

The ExecCredential API went GA in 1.22

@margocrawf Where was this mentioned? I don't see anything about it in the 1.22 changelog. https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md

@enj
Copy link
Member

enj commented Nov 2, 2022

The ExecCredential API went GA in 1.22

@margocrawf Where was this mentioned? I don't see anything about it in the 1.22 changelog. https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md

@rittneje https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md#external-credential-providers

@imriz imriz mentioned this pull request Jan 24, 2023
Closed
@liggitt liggitt mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj requested changes

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.24
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@margocrawf @k8s-ci-robot @enj @k8s-triage-robot @liggitt @rittneje