Add env var to verify-typecheck for serial execution

[eddiezane]

What type of PR is this?

/kind flake

What this PR does / why we need it:

This PR makes it possible to set serial execution for verify-typecheck.sh. This is needed bring down the memory usage of the flaking job that is getting oom killed. This is due to Go 1.17 requiring double the amount of memory for this (see golang/go#49035).

Which issue(s) this PR fixes:

Ref #107702

Special notes for your reviewer:

I'm not sure if this is the best way to pass these along.

Another option is to make typecheck support an env var

kubernetes/test/typecheck/main.go

Line 42 in 4763d75

parallel = flag.Int("parallel", 2, "limits how many platforms can be checked in parallel. 0 means no limit.")

.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[eddiezane]

/sig testing
/priority important-soon
/assign @liggitt

[liggitt]

I'm not sure if this is the best way to pass these along.

I'm not sure either

/assign @thockin
(or alternate) for makefile voodoo

[aojea]

why not defaulting the tool to serial instead?

	serial     = flag.Bool("serial", false, "don't type check platforms in parallel (equivalent to --parallel=1)")

[thockin]

I'm skeptical. Does every verify* script take this argument and know to pass it down? At least a few others use "$@", so I'd expect them to break...

$ grep '$@' hack/verify-*.sh
hack/verify-boilerplate.sh:done < <("${boiler}" "$@")
hack/verify-golangci-lint.sh:    golangci-lint run "$@" >&2 || res=$?
hack/verify-import-aliases.sh:go run cmd/preferredimports/preferredimports.go "$@" || ret=$?
hack/verify-typecheck.sh:go run test/typecheck/main.go "$@" || ret=$?

If the goal is to pass this down to a single script, like verify-typecheck.sh, I think you want something more like make verify TYPECHECK_ARGS="--parallel=1" and then you can use that inside the typecheck script.

Or just change to tool for now, and revert it when our required Go version is safe again.

[thockin]

This variable is undefined and very ambiguously named, at best.

[thockin]

Is the goal to pass the args to EVERY verify-* script? Is that right?

[thockin]

simpler?

TYPECHECK_SERIAL="${TYPECHECK_SERIAL:-false}"
hack/run-in-gopath.sh \
   go run test/typecheck/main.go "$@" --serial "$TYPECHECK_SERIAL" || ret=$?

[thockin]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dims]

/triage accepted