-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csi_attacher: improve attach/detach timeout message #108628
csi_attacher: improve attach/detach timeout message #108628
Conversation
@RomanBednar: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @RomanBednar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks for improving this! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2a62b3e
to
0e39882
Compare
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
If we time out waiting for volume to be attached the message given to user is not informative enough: "Attach timeout for volume vol-123" It would be better if we provide more information on what's going on and even include name of the driver that's causing the problem, e.g.: "timed out waiting for external-attacher of ebs.csi.aws.com CSI driver to attach volume vol-123"
0e39882
to
f17f003
Compare
/test pull-kubernetes-e2e-kind-ipv6 |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If we time out waiting for volume to be attached the message given
to user is not informative enough:
"Attach timeout for volume vol-123"
It would be better if we provide more information on what's going on
and even include name of the driver that's causing the problem, e.g.:
"Timed out waiting for external-attacher of ebs.csi.aws.com CSI driver to attach volume vol-123"
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Tested locally (local-up-cluster.sh):
#kubectl -n testdisk describe pod/efs-app
BEFORE PATCH:
AFTER PATCH:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: