Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PreFilter interface to return a PreFilterResult #108648

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Update PreFilter interface to return a PreFilterResult #108648

merged 2 commits into from
Mar 15, 2022

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Mar 10, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Updates the scheduler framework's PreFilter interface to return a new type named PreFilterResult; this allows PreFilter to influence which nodes to evaluate downstream (Filter and beyond).

The first plugin to use this is NodeAffinity which looks for node.Name MatchField terms; if exist, the pod is only evaluated against the matching nodes

This can be extended to also influence the number of nodes to score, but that is left for the future.

Which issue(s) this PR fixes:

Part of ##108606

Special notes for your reviewer:

Does this PR introduce a user-facing change?

PreFilter extension in the scheduler framework now returns not only status but also PreFilterResult

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

@ahg-g: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@ahg-g ahg-g changed the title Update PreFilter interface to return a PreFilterResult [WIP] Update PreFilter interface to return a PreFilterResult Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@ahg-g ahg-g mentioned this pull request Mar 10, 2022
Closed
@ahg-g ahg-g force-pushed the ahg-ds branch 2 times, most recently from c9900f1 to e53b90d Compare March 11, 2022 03:37
@ahg-g ahg-g changed the title [WIP] Update PreFilter interface to return a PreFilterResult Update PreFilter interface to return a PreFilterResult Mar 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Mar 11, 2022

/assign @alculquicondor @Huang-Wei

alculquicondor
alculquicondor reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for squash

@ahg-g
Copy link
Member Author

ahg-g commented Mar 14, 2022

squashed into two commits.

I had to remove the underscore from "node_x" names in the affinity tests because they were causing issues with hack/verify-flags-underscore.py

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Mar 14, 2022

/retest

Huang-Wei
Huang-Wei reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat! Just one nit, LGTM otherwise.

pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Mar 14, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@Huang-Wei
Copy link
Member

/lgtm still

@k8s-ci-robot k8s-ci-robot merged commit d7bd0d4 into kubernetes:master Mar 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 15, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Mar 15, 2022

/cc @MaciekPytel @x13n

@x13n x13n mentioned this pull request Mar 17, 2022
Closed
@wojtek-t wojtek-t mentioned this pull request Mar 21, 2022
Open
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Open
@yibozhuang yibozhuang mentioned this pull request Apr 14, 2022
Closed
@yibozhuang yibozhuang mentioned this pull request May 6, 2022
Closed
@kerthcet kerthcet mentioned this pull request May 18, 2022
Closed
@sanposhiho sanposhiho mentioned this pull request Nov 6, 2022
Closed
@1978629634 1978629634 mentioned this pull request Dec 10, 2022
Closed
@dongjiang1989 dongjiang1989 mentioned this pull request May 25, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@denkensk denkensk denkensk left review comments

@kerthcet kerthcet kerthcet left review comments

@cofyc cofyc Awaiting requested review from cofyc

@damemi damemi Awaiting requested review from damemi

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@x13n x13n Awaiting requested review from x13n

Assignees

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ahg-g @k8s-ci-robot @denkensk @Huang-Wei @alculquicondor @kerthcet