Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pod overhead test to be made a Conformance #108714

Merged
merged 1 commit into from
Mar 17, 2022
Merged

pod overhead test to be made a Conformance #108714

merged 1 commit into from
Mar 17, 2022

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind cleanup
/area test
/sig node

Related: #96524

What this PR does / why we need it:

Adding a conformance test for PodOverhead field and preparing for making RuntimeClass tests as conformance

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 15, 2022
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 15, 2022
Merged
@SergeyKanzhelev
Copy link
Member Author

/retest

@SergeyKanzhelev
Copy link
Member Author

/triage accepted
/priority important-soon
/assign @ehashman

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2022
bobbypage
bobbypage reviewed Mar 16, 2022
View reviewed changes
test/e2e/common/node/runtimeclass.go Outdated Show resolved Hide resolved
test/e2e/common/node/runtimeclass.go Outdated Show resolved Hide resolved
test/e2e/common/node/runtimeclass.go Outdated Show resolved Hide resolved
@SergeyKanzhelev
Copy link
Member Author

/retest

@bobbypage
Copy link
Member

Thanks for updates!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@SergeyKanzhelev
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a7740c8 into kubernetes:master Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 17, 2022
SIG Node CI/Test Board automation moved this from Triage to Done Mar 17, 2022
SIG Node PR Triage automation moved this from Triage to Done Mar 17, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the podOverheadConformance branch March 17, 2022 17:18
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage bobbypage left review comments

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@bobbypage bobbypage

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeyKanzhelev @k8s-ci-robot @bobbypage @yangjunmyfm192085 @ehashman