Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TODOs from http package and prober #108803

Merged
merged 1 commit into from Jun 1, 2022
Merged

remove TODOs from http package and prober #108803

merged 1 commit into from Jun 1, 2022

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind cleanup
/area kubelet
/sig node

What this PR does / why we need it:

This is a clean up of old workaround with three http connection pools that was fixed in golang/go#22091. Also removed a few old TODOs.

Special notes for your reviewer:

I was looking at something else in this code and found that these old TODOs will unlikely be fixed, and the workaround with three http pools is unnatural and not needed any longer. Just a simple clean up.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2022
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 18, 2022
tallclair
tallclair reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@ehashman
Copy link
Member

/priority backlog
/triage accepted
/lgtm cancel

need to fix the linting error

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
ehashman
ehashman reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the linter failure

pkg/kubelet/prober/prober.go
exec execprobe.Prober
// probe types needs different httpprobe instances so they don't
// share a connection pool which can cause collisions to the
// same host:port and transient failures. See #49740.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.b. #49740 was a workaround, fixed upstream in golang 1.10+ with golang/go#22091

Should be safe to collapse these.

@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 21, 2022
@matthyx
Copy link
Contributor

matthyx commented May 4, 2022

I guess we can continue with this one...
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@matthyx
Copy link
Contributor

matthyx commented May 4, 2022

Ping @tallclair can you approve?

@matthyx matthyx moved this from Waiting on Author to Needs Approver in SIG Node PR Triage May 4, 2022
@tallclair
Copy link
Member

no, looks like you need a sig-node-approver (I already approved, but it only counts for pkg/kubelet/prober)

@matthyx
Copy link
Contributor

matthyx commented May 13, 2022

/assign @mrunalp

@aojea
Copy link
Member

aojea commented May 13, 2022

/lgtm

nice, this divide by 3 the number of clients

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 737f706 into kubernetes:master Jun 1, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 1, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the httpProbeMinorCleanup branch June 1, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@tallclair tallclair tallclair left review comments

@mrunalp mrunalp mrunalp approved these changes

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@mrunalp mrunalp

@ehashman ehashman

@aojea aojea

@matthyx matthyx

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SergeyKanzhelev @ehashman @matthyx @tallclair @aojea @k8s-ci-robot @mrunalp