New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all device-plugin logic into separate 'plugin' package under the devicemanager #109016
Refactor all device-plugin logic into separate 'plugin' package under the devicemanager #109016
Conversation
/sig node |
8f2be3a
to
b63f706
Compare
9eebca5
to
ad5c6a6
Compare
ad5c6a6
to
dab4fa1
Compare
Now that main has been frozen for 1.24 /unhold /cc @fromanirh @swatisehgal @kad @bart0sh |
/lgtm |
This is the first step towards being able to support a new plugin API version in parallel with the existing one. Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
213f65c
to
57f8b31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm for test/images changes
/approve
/hold for others to review
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klueska, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
/unhold |
Apologies for the delay in getting to this. Looks good. Looking forward to the upcoming changes in the device manager that would allow to service multiple plugin APIs at once! /lgtm |
We encountered an issue with this PR. The device plugin simply returns
I guess our device plugin probably should return an empty object instead of nil. However, I couldn't find any document that states this enforcement. Maybe this could be an enhancement to the device plugin document. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR moves all logic specific to interacting with a device plugin into a separate
plugin
directory under thedevicemanager
. This change makes the code much more readable and is in preparation for an upcoming change to allow thedevicemanager
to service multipleplugin
APIs at once (as we begin to introduce av1beta2
API).The core of the logic was moved mostly unchanged, and the tests were only updated to accommodate the new structure. None of the core logic of the tests themselves has changed.
Special notes for your reviewer:
Feel free to begin reviewing this PR, but it should not land in master until after the 1.24 release branch has been cut and master is opened up again for 1.25 contributions.
/hold
Does this PR introduce a user-facing change?