Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #108752: Fix: Clean job tracking finalizer from orphan pods #109020

Merged
merged 5 commits into from Apr 5, 2022
Merged

Automated cherry pick of #108752: Fix: Clean job tracking finalizer from orphan pods #109020

merged 5 commits into from Apr 5, 2022

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Mar 25, 2022 •
edited by liggitt

Cherry pick of #108752 on release-1.23.

#108752: Fix: Clean job tracking finalizer from orphan pods
#109025: Reduce number of pods in Job+GC tests

For details on the cherry pick process, see the cherry pick requests page.

Fix a 1.23 regression where the job controller might not remove the job tracking finalizer from pods when deleting a job, or when the pod is orphan

@alculquicondor
Add integration test for orphan pods when there is GC
8077e58 
Change-Id: I04cd70725fd1830be8daf2dca53f67bc10a379b7
@alculquicondor
Add test for Background delete propagation
3b84efd 
Change-Id: I033e6fb04933c64cfe6490d1019333745d58c423
@alculquicondor
Fix: Clean job tracking finalizer from orphan pods
56d9c45 
Change-Id: I04cd70725fd1830be8daf2dca53f67bc10a379b7
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2022
@alculquicondor
Copy link
Member Author

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 25, 2022
soltysh
soltysh approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority backlog
/triage accepted
/lgtm
/approve
/kind bug

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2022
@alculquicondor
Remove finalizer when orphaned
f75e1b0 
Change-Id: Id88a28755660812a274dffab2693cb8a0ef4235c
@alculquicondor alculquicondor force-pushed the automated-cherry-pick-of-#108752-upstream-release-1.23 branch from cf08a2d to f75e1b0 Compare March 25, 2022 15:34
@alculquicondor
Copy link
Member Author

/hold
there are concerns that the integration test is too heavy. I'm going to reduce the load.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2022
@alculquicondor
Reduce number of pods in Job+GC tests
9342552 
To reduce the load of the integration tests. This change reduces the runtime of each test in half.

Change-Id: I71bcaadf3809643c63bb0f6b73c28778d37d8967
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Mar 29, 2022 •
edited

Also added #109025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2022
@alculquicondor
Copy link
Member Author

/retest

soltysh
soltysh approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@alculquicondor
Copy link
Member Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 29, 2022 13:55
@alculquicondor
Copy link
Member Author

/retest

3 similar comments
@alculquicondor
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 30, 2022
@alculquicondor
Copy link
Member Author

ping @kubernetes/release-managers

@alculquicondor alculquicondor changed the title Automated cherry pick of #108752: Add integration test for orphan pods when there is GC Automated cherry pick of #108752: Fix: Clean job tracking finalizer from orphan pods Mar 31, 2022
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, justaugustus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Member Author

/retest

1 similar comment
@alculquicondor
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f2f37b6 into kubernetes:release-1.23 Apr 5, 2022
@alculquicondor alculquicondor mentioned this pull request Apr 14, 2022
Closed
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 9, 2023
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@soltysh soltysh soltysh approved these changes

@foxish foxish Awaiting requested review from foxish

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alculquicondor @soltysh @k8s-ci-robot @justaugustus @liggitt