New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of a function that returns the wait state of the scheduler #109478
Conversation
@shintard: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @shintard! |
Hi @shintard. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
The test seems to be failing, is there anything else I need to add? |
/retest |
It's better to add tests, you can rename |
thank you. |
@kerthcet I added some test code. |
thx. squashed |
@shintard You need to squash all the commits to one. |
93d6154
to
b0112f9
Compare
@denkensk I misunderstood the meaning of squash. |
/lgtm |
/hold cancel |
/release-note-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nits
(Let me remove |
@sanposhiho thx for the review. |
Co-authored-by: Alex Wang <453102040@qq.com>
91d6f13
to
2298440
Compare
/retest |
@shintard: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Did you open a bug for the flaky tests? |
No. |
Created: #109785 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I thought it would be useful to have this function when I am building my own Kubernetes scheduler, so I sent a PR.
Just as Success has an IsSuccess function, it would be nice to have an IsWait for Wait.
I am new to Kubernetes, so maybe this is a pointless change.
But I sent this PR in the hope that there is even a small chance of keeping the code clean. If it's useless, feel free to delete it!
Any reviews would be greatly appreciated!
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: