Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the image for node performance tests - model expected tensorflow… #109551

Merged
merged 1 commit into from May 4, 2022
Merged

fix the image for node performance tests - model expected tensorflow… #109551

merged 1 commit into from May 4, 2022

Conversation

SergeyKanzhelev
Copy link
Member

… version <1.9

What type of PR is this?

/kind failing-test
/sig node
/area test

What this PR does / why we need it:

Fix the image for node performance tests

Which issue(s) this PR fixes:

Towards: #109295 (will need to update image later)

Special notes for your reviewer:

Just lock tensorflow version for now. Switching to more actual model may be done later

Does this PR introduce a user-facing change?

NONE

@SergeyKanzhelev
fix the image for node performance tests - model expected tensorflow…
462e1ae 
… version <1.9

Change-Id: I116cc38eac20f7cdafb975c88ee9a0e7ec667861
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 20, 2022
@SergeyKanzhelev
Copy link
Member Author

@dims would this PR be OK while in test freeze? This image is only used in node performance tests

(also will need another PR when image will be actually built)

@SergeyKanzhelev
Copy link
Member Author

/retest

endocrimes
endocrimes approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2022
@endocrimes
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 20, 2022
@endocrimes endocrimes moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Apr 20, 2022
@endocrimes
Copy link
Member

/assign @dims

@dims
Copy link
Member

dims commented Apr 27, 2022

/approve
/lgtm

won't land until master reopens.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, endocrimes, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board May 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit fa69786 into kubernetes:master May 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 4, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the fixTensorflow branch June 1, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SergeyKanzhelev @endocrimes @dims @k8s-ci-robot