Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resizing of ephemeral volumes #109987

Merged
merged 2 commits into from May 13, 2022
Merged

Fix resizing of ephemeral volumes #109987

merged 2 commits into from May 13, 2022

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented May 11, 2022 •
edited

Fixes expansion of ephemeral volumes by checking of PV in volumeSpec

/sig storage

Allow expansion of ephemeral volumes

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

@gnufied: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 11, 2022
@gnufied
Copy link
Member Author

gnufied commented May 11, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2022
@jsafrane
Copy link
Member

/priority important-soon
Generic ephemeral volumes cannot be resized now.

@gnufied would it be (easily) possible to add an e2e tests for resizing generic ephemeral volumes?

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 12, 2022
@jsafrane
Copy link
Member

/retest
DownwardAPI tests failed, not related to this PR

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3441850 into kubernetes:master May 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 13, 2022
This was referenced May 18, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2022
@k8s-ci-robot
Merge pull request #110118 from gnufied/automated-cherry-pick-of-#109…
be8f626 
…987-upstream-release-1.23

Automated cherry pick of #109987: Fix resizing of ephemeral volumes
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2022
@k8s-ci-robot
Merge pull request #110117 from gnufied/automated-cherry-pick-of-#109…
8ef32e6 
…987-upstream-release-1.24

Automated cherry pick of #109987: Fix resizing of ephemeral volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnufied @k8s-ci-robot @jsafrane