Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Build image 3.5.4-0 #110031

Merged
merged 1 commit into from May 28, 2022
Merged

etcd: Build image 3.5.4-0 #110031

merged 1 commit into from May 28, 2022

Conversation

mk46
Copy link
Member

@mk46 mk46 commented May 13, 2022

What type of PR is this?

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

Build Image for etcd v3.5.4.

Which issue(s) this PR fixes:

Part of #109707
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mk46. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from fejta and jpbetz May 13, 2022 08:06
@mk46 mk46 mentioned this pull request May 13, 2022
Merged
@mk46
Copy link
Member Author

mk46 commented May 13, 2022

/cc @serathius

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@mk46
Copy link
Member Author

mk46 commented May 13, 2022

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot
Copy link
Contributor

@mk46: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-e2e-kind-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mk46
Copy link
Member Author

mk46 commented May 16, 2022

Hi @neolit123, JFYI. Looking for ok-to-test to pass failing test(pull-kubernetes-e2e-kind-ipv6).
Thanks!!

@serathius
Copy link
Contributor

/retest

@mk46
Copy link
Member Author

mk46 commented May 17, 2022

/assign @lavalamp

@roycaihw
Copy link
Member

/cc @jpbetz @wenjiaswe
/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label May 17, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 17, 2022
@dims dims removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2022
@dims
Copy link
Member

dims commented May 27, 2022

/approve
/lgtm

/hold if you need additional reviewers feel free to remove hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2022
@dims dims added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mk46

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mk46
Copy link
Member Author

mk46 commented May 28, 2022

/remove-hold
Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit f3264dd into kubernetes:master May 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta Awaiting requested review from fejta

@jpbetz jpbetz Awaiting requested review from jpbetz

@serathius serathius Awaiting requested review from serathius

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@dims dims

@lavalamp lavalamp

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mk46 @k8s-ci-robot @serathius @roycaihw @dims @lavalamp