New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customresouce: clean up the storage constructor #110130
customresouce: clean up the storage constructor #110130
Conversation
The distinction between Storage and REST was lost when the constructor for the latter began to do almost but not all of the former. No other callers exist for newREST(), so merging the constructors allows us to be more clear with what we're constructing and keeps us from shallow-copying the genericregistry.Store every time even when no status subresource is requested. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
/triage accepted |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
The distinction between Storage and REST was lost when the constructor
for the latter began to do almost but not all of the former. No other
callers exist for newREST(), so merging the constructors allows us to be
more clear with what we're constructing and keeps us from
shallow-copying the genericregistry.Store every time even when no status
subresource is requested.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/kind cleanup
/sig api-machinery
/assign @sttts