customresource: stop shallow-copying metadata

[stevekuznetsov]

We no longer mutate anything in the genericregistry.Store, and the
self-link is deprecated, unset and not persisted in etcd. There is no
need to do the shallow-copies of metadata any longer.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/kind cleanup
/sig api-machinery

NONE

/assign @sttts

[stevekuznetsov]

This reverts cd10f28

[leilajal]

/triage accepted

[sttts]

I think this is safe. But giving @wojtek-t and @p0lyn0mial the chance to look.

[wojtek-t]

Hmm - on one hand we're not doing any copying for non-CRD and it should behave the same way across CRDs and built-ins:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L326_L373

OTOH, we have never been doing anything there, so I'm yet convinced.

Where was the copying happening for built-in resources and why that mechanism wasn't effective for CRDs so that we had to fix that in the PR that this one is reverting?

[stevekuznetsov]

I'm not sure, @sttts was the original author here :D

[sttts]

@wojtek-t see the old comment. Native types have Items []NonPointerType. Hence, adding items to the list shallow copies. CRDs are unstructured and hence no shallow copy.

[wojtek-t]

OK - thanks. Forgot about that.

I think without selflink setting it should be safe.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment