Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to new level of agnhost #110176

Merged
merged 1 commit into from May 24, 2022
Merged

update to new level of agnhost #110176

merged 1 commit into from May 24, 2022

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 23, 2022 •
edited

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 23, 2022
@k8s-ci-robot
Copy link
Contributor

@deads2k: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 23, 2022
@deads2k deads2k mentioned this pull request May 23, 2022
Merged
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 23, 2022
@aojea
Copy link
Member

aojea commented May 23, 2022

/cc

@k8s-ci-robot k8s-ci-robot requested a review from aojea May 23, 2022 18:38
@deads2k
Copy link
Contributor Author

deads2k commented May 23, 2022

forgot to push, starting again.

/test all

@deads2k
Copy link
Contributor Author

deads2k commented May 23, 2022

@aojea trouble building the image? locally I see

[deads@fedora origin]$ oc logs -f service-test-9kqmn
exec /agnhost: no such file or directory

@aojea
Copy link
Member

aojea commented May 24, 2022 •
edited

/retest

the anghost binary needs to be built with CGO_ENABLED=0 go build in order to run in alpine 🤷 , pushed a new image

@aojea
Copy link
Member

aojea commented May 24, 2022 •
edited

@aojea trouble building the image? locally I see

[deads@fedora origin]$ oc logs -f service-test-9kqmn
exec /agnhost: no such file or directory

@deads2k fixed, seems this is good to go , at least in CI is not failing

@deads2k deads2k mentioned this pull request May 24, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022
@deads2k deads2k changed the title [wip] proof of agnhost change update to new level of agnhost May 24, 2022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented May 24, 2022

/kind bug
/sig networking
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 24, 2022
@k8s-ci-robot
Copy link
Contributor

@deads2k: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug
/sig networking
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 24, 2022
@deads2k
Copy link
Contributor Author

deads2k commented May 24, 2022

now a real update

/hold cancel
/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 24, 2022
@deads2k
Copy link
Contributor Author

deads2k commented May 24, 2022

/retest

@aojea
Copy link
Member

aojea commented May 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit f8c77fd into kubernetes:master May 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 24, 2022
@aojea
Copy link
Member

aojea commented May 25, 2022

hmm https://storage.googleapis.com/k8s-triage/index.html?sig=network#7ccacb7807a6b800df8c

things started to fail on these tests, that use the healthz endpoint for readiness

@aojea
Copy link
Member

aojea commented May 25, 2022

damn , this is breaking the behavior, a SIGTERM never exit 🤕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@SataQiu SataQiu Awaiting requested review from SataQiu

@aojea aojea Awaiting requested review from aojea

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deads2k @k8s-ci-robot @aojea