Fix up some kubernetes service reconciling code organization. #110234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the endpoint reconcilers got split out of pkg/controlplane, GetMasterServiceUpdateIfNeeded() got moved to pkg/controlplane/reconcilers, even though it needs to be kept in sync with CreateOrUpdateMasterServiceIfNeeded() which stayed in pkg/controlplane. (And everything else in pkg/controlplane/reconcilers is about the Endpoints not the Service anyway.) So move it back. On the flip side, the implementation of masterCountEndpointReconciler got moved to pkg/controlplane/reconcilers, but its unit tests didn't. So belatedly fix that.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/api-machinery
|
straight move and narrowing of scope. /lgtm |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When the endpoint reconcilers got split out of
pkg/controlplane,GetMasterServiceUpdateIfNeeded()got moved topkg/controlplane/reconcilers, even though it needs to be kept in sync withCreateOrUpdateMasterServiceIfNeeded()which stayed inpkg/controlplane. (And everything else inpkg/controlplane/reconcilersis about the Endpoints not the Service anyway.) So move it back.On the flip side, the implementation of
masterCountEndpointReconcilergot moved topkg/controlplane/reconcilers, but its unit tests didn't. So belatedly fix that.Which issue(s) this PR fixes:
None; I'm doing some cleanup/refactoring of the endpoint reconciling code in preparation for dual-stack apiserver support (KEP-2438).
Does this PR introduce a user-facing change?
/assign @deads2k