Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSINodeExpandSecret featuregate has to be 1.25 based #110244

Merged
merged 1 commit into from May 28, 2022
Merged

CSINodeExpandSecret featuregate has to be 1.25 based #110244

merged 1 commit into from May 28, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented May 27, 2022 •
edited

At present the CSINodeExpandSecret feature gate has been tagged with
1.24 in the source code comments incorrectly. This commit address
the same

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

NONE

Additional Note For Reviewer:
Eventhough all approvals were in place (#105963) , this feature missed the codefreeze deadline of 1.24 and exception was not granted which made it go unnoticed.

@humblec
CSINodeExpandSecret featuregate has to be 1.25 based
055512b 
At present the CSINodeExpandSecret feature gate has been tagged with
1.24 in the source code comments incorrectly. This commit address
the same

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 27, 2022
@k8s-ci-robot
Copy link
Contributor

@humblec: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 27, 2022
@humblec
Copy link
Contributor Author

humblec commented May 27, 2022

Cc @dims

@dims
Copy link
Member

dims commented May 27, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@ialidzhikov
Copy link
Contributor

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit dfefd5a into kubernetes:master May 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@humblec @k8s-ci-robot @dims @ialidzhikov