Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods #110260

Merged
merged 6 commits into from Jun 3, 2022
Merged

Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods #110260

merged 6 commits into from Jun 3, 2022

Conversation

robscott
Copy link
Member

Cherry pick of #110255 on release-1.22.

#110255: add pod util to verify pod is terminal

For details on the cherry pick process, see the cherry pick requests page.

aojea and others added 6 commits May 27, 2022 23:43
@aojea @robscott
add pod util to verify pod is terminal
add6f8a 
pods on phase succeeded or failed are guaranteed to have all containers
stopped and to not ever regress
@aojea @robscott
endpointslices: terminal pods doesn't receive enpoints
7670e5c
@aojea @robscott
endpoints controller: don't consider terminal endpoints
7b8eb0b 
Terminal pods, whose phase its Failed or Succeeded, are guaranteed
to never regress and to be stopped, so their IPs never should
be published on the Endpoints.
@aojea @robscott
e2e test for evicted pods
c666bb5
@aojea @robscott
e2e: services with evicted pods doesn't have endpoints
d66c4f8
@robscott
Updating e2e test to check EndpointSlices and Endpoints as well
673ac4a
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 27, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels May 27, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 27, 2022
@robscott
Copy link
Member Author

/sig network
/priority important-soon
/triage accepted
/cc @aojea @bowei @swetharepakula
/assign @thockin

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 27, 2022
@thockin thockin changed the title Automated cherry pick of #110255: add pod util to verify pod is terminal Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods May 28, 2022
@thockin
Copy link
Member

thockin commented May 28, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2022
@robscott
Copy link
Member Author

/retest

@robscott
Copy link
Member Author

cc @kubernetes/release-managers

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jun 1, 2022
@puerco
Copy link
Member

puerco commented Jun 3, 2022

Thanks @robscott !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 3, 2022
@puerco
Copy link
Member

puerco commented Jun 3, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0d99df5 into kubernetes:release-1.22 Jun 3, 2022
SIG Node CI/Test Board automation moved this from Archive-it to Done Jun 3, 2022
SIG Node PR Triage automation moved this from Triage to Done Jun 3, 2022
This was referenced Oct 24, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@aojea aojea Awaiting requested review from aojea

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@puerco puerco

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @thockin @k8s-ci-robot @puerco @aojea