test/e2e_kubeadm: add URL scheme test for node CRI annotations #110287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
4 tasks
k8s-ci-robot
added
area/kubeadm
area/test
sig/cluster-lifecycle
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
approved
The tests in nodes_test.go check if the Node objects in a kubeadm cluster are annotated with a CRI socket path. It is used by kubeadm to store a CRI socket per node. Add a new test condition to verify if the CRI socket path is prefixed with URL scheme "unix://".
neolit123
force-pushed
the
1.25-add-url-scheme-e2e-test-for-cri-socket
branch
from
6e770df
to
2a18a2d
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The tests in nodes_test.go check if the Node objects
in a kubeadm cluster are annotated with a CRI socket
path. It is used by kubeadm to store a CRI socket per node.
Add a new test condition to verify if the CRI socket path
is prefixed with URL scheme "unix://".
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#2426
Special notes for your reviewer:
The changes in 1.24 were made so that we always prefix with URL scheme.
This test change will be added to 1.25, so even in our skew tests (kubeadm 1.24 vs k8s/test suite 1.25) it should be OK.
Note: "unix://" is valid here given kubeadm has no non-unix tests in CI (e.g. Windows npipes URL schemes)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: