Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance assertions in test/e2e/windows #110303

Merged
merged 1 commit into from Jun 2, 2022
Merged

enhance assertions in test/e2e/windows #110303

merged 1 commit into from Jun 2, 2022

Conversation

hunknownz
Copy link

Signed-off-by: hunknownz klercc37@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Better output for developers when tests fail.

Which issue(s) this PR fixes:

Fixes part of #105678

Special notes for your reviewer:

After this PR:

.../kubernetes/test/e2e/windows$ git grep 'Expect.*Equal([^,]*, *\(true\|false\)' | wc -l
0

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 31, 2022
@k8s-ci-robot
Copy link
Contributor

@hunknownz: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @hunknownz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 31, 2022
@hunknownz
Copy link
Author

/assign @pohly

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 31, 2022
pohly
pohly reviewed May 31, 2022
View reviewed changes
test/e2e/windows/host_process.go Outdated
framework.ExpectEqual(beforeMetrics.StartedContainersErrorCount < afterMetrics.StartedContainersErrorCount, true, "Count of started HostProcess errors containers should increase")
framework.ExpectEqual(beforeMetrics.StartedInitContainersCount < afterMetrics.StartedInitContainersCount, true, "Count of started HostProcess init containers should increase")
framework.ExpectEqual(beforeMetrics.StartedInitContainersErrorCount < afterMetrics.StartedInitContainersErrorCount, true, "Count of started HostProcess errors init containers should increase")
gomega.Expect(beforeMetrics.StartedContainersCount).To(gomega.BeNumerically("<", afterMetrics.StartedContainersCount), fmt.Sprintf("Count of started HostProcess containers should increase: >= %v", afterMetrics.StartedContainersCount))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below the gomega.BeNumerically already takes care of printing the two values, so they don't need to be included in the explanation.

Also note that Expect does the printf formatting itself, so fmt.Sprintf would not be needed here.

@hunknownz
enhance assertions in test/e2e/windows
fdb43cc 
Signed-off-by: hunknownz <klercc37@gmail.com>
pohly
pohly approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@pohly pohly mentioned this pull request May 31, 2022
Open
22 tasks
@hunknownz
Copy link
Author

/assign @marosset

@hunknownz
Copy link
Author

@pohly which owner should I assign?
Screen Shot 2022-06-02 at 9 21 38 PM

@marosset
Copy link
Contributor

marosset commented Jun 2, 2022

I can take a look today.

/test pull-kubernetes-e2e-capz-windows-containerd

@marosset marosset added this to In Progress (v1.25) in SIG-Windows Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

@hunknownz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-windows-containerd fdb43cc link false /test pull-kubernetes-e2e-capz-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor

marosset commented Jun 2, 2022

The tests that did fail are known issues are should be addressed with #110235

@marosset
Copy link
Contributor

marosset commented Jun 2, 2022

/approve
/assign @jsturtevant

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hunknownz, marosset, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit e562e93 into kubernetes:master Jun 2, 2022
SIG-Windows automation moved this from In Progress (v1.25) to Done (v1.25) Jun 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 2, 2022
@hunknownz
Copy link
Author

I can take a look today.

/test pull-kubernetes-e2e-capz-windows-containerd

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@pohly pohly

@jsturtevant jsturtevant

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG-Windows
  
Done (v1.25)
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hunknownz @k8s-ci-robot @marosset @pohly @jsturtevant