New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unnecessary json.Marshal #110353
Drop unnecessary json.Marshal #110353
Conversation
yaml.Marshal under the covers invokes json.Marshal and then JSONToYAML conversion which was done here manually.
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
/sig cli
What this PR does / why we need it:
I've spotted that while looking through @brianpursley 's #109085
yaml.Marshal
under the covers invokesjson.Marshal
and thenJSONToYAML
conversion which was done here manually.See here:
kubernetes/vendor/sigs.k8s.io/yaml/yaml.go
Lines 16 to 28 in 03d0e2c
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/assign @ardaguclu
Does this PR introduce a user-facing change?