Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code optimization: deal with error first to prevent unnecessary computing #110372

Merged
merged 1 commit into from Jun 9, 2022
Merged

code optimization: deal with error first to prevent unnecessary computing #110372

merged 1 commit into from Jun 9, 2022

Conversation

lokichoggio
Copy link
Contributor

@lokichoggio lokichoggio commented Jun 3, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

optimize code under pkg/scheduler/framework/plugins/podtopologyspread

Special notes for your reviewer:

deal with error first to prevent unnecessary computing
move the definition of variables to their most recent usage

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

@lokichoggio: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @lokichoggio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 3, 2022
@kerthcet
Copy link
Member

kerthcet commented Jun 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2022
kerthcet
kerthcet reviewed Jun 3, 2022
View reviewed changes
pkg/scheduler/framework/plugins/podtopologyspread/filtering.go
@@ -359,6 +352,13 @@ func (pl *PodTopologySpread) Filter(ctx context.Context, cycleState *framework.C
continue
}

selfMatchNum := 0
Copy link
Member

@kerthcet kerthcet Jun 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add some explanations what this PR for. I guess you want to fail fast here, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokichoggio It's weird to call it "fail fast". I guess you meant "move the definition of variables to their most recent usage"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em...... yes, fail fast is a little weird, but I think the most valuable thing here is to prevent unnecessary computing when error in calculating minMatchNum. Whatever, fail fast is not that accurate.

@lokichoggio
Copy link
Contributor Author

/assign @Huang-Wei

kerthcet
kerthcet reviewed Jun 5, 2022
View reviewed changes
pkg/scheduler/framework/plugins/podtopologyspread/filtering.go Outdated
}

pair := topologyPair{key: tpKey, value: tpVal}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the blank line here.

@kerthcet
Copy link
Member

kerthcet commented Jun 5, 2022

Thanks @lokichoggio plz squash the commit.

@lokichoggio
Copy link
Contributor Author

Thanks @lokichoggio plz squash the commit.

ok now

@kerthcet
Copy link
Member

kerthcet commented Jun 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
denkensk
denkensk reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@denkensk denkensk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the tile to make it readable?

@Huang-Wei
Copy link
Member

Can you rename the tile to make it readable?

Yes, please describe the intention concisely.

@lokichoggio lokichoggio changed the title code optimization code optimization: deal with error first to prevent unnecessary computing Jun 9, 2022
@lokichoggio
Copy link
Contributor Author

Can you rename the tile to make it readable?

Yes, please describe the intention concisely.

updated, thanks

@Huang-Wei
Copy link
Member

/approve
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, lokichoggio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit fa25826 into kubernetes:master Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk denkensk left review comments

@kerthcet kerthcet kerthcet left review comments

@chendave chendave Awaiting requested review from chendave

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@Huang-Wei Huang-Wei

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lokichoggio @k8s-ci-robot @kerthcet @Huang-Wei @denkensk