FakeClient: list pod err after an pod evicted

[LY-today]

What happened?

After I evicted an pod, I performed the operation of the full list instance, but found something that did not meet expectations

item[0]: can't assign or convert v1beta1.Eviction into v1.Pod

What did you expect to happen?

After pods are evicted, non-evicted ones can be listed normally

How can we reproduce it (as minimally and precisely as possible)?

package main

import (
	"context"
	v1 "k8s.io/api/core/v1"
	policy "k8s.io/api/policy/v1"
	meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/client-go/kubernetes/fake"
)

func main() {
	client := fake.NewSimpleClientset()
	client.CoreV1().Pods("default").Create(context.Background(),&v1.Pod{
		ObjectMeta: meta_v1.ObjectMeta{
			Name:      "pod-1",
			Namespace: "default",
		},
	},meta_v1.CreateOptions{})
	_ = client.CoreV1().Pods("default").EvictV1(context.Background(), &policy.Eviction{
		ObjectMeta: meta_v1.ObjectMeta{
			Name: "pod-1",
		},
	})
	_, err := client.CoreV1().Pods("default").List(context.Background(),meta_v1.ListOptions{})
	//err: item[0]: can't assign or convert v1beta1.Eviction into v1.Pod
}

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

v1.20.0

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[endocrimes]

#110425

/sig api-machinery
/remove-sig node

[leilajal]

/remove-sig api-machinery

[leilajal]

/assign @yliaog since you are tagged on the PR. Thanks!
/triage accepted

[LY-today]

/sig testing

[LY-today]

@yliaog If you have time, please help to look at this pr, thanks

[liggitt]

this is a general issue with subresources that accept create requests of different object types than the parent resource

see also:

• client-go/testing: Can’t list pods after creating eviction #80354
• client-go/testing: inconsistent behavior around evictions #71598
• client-go/testing: Straighten out fake implementation of Evictions #71599
• client-go/testing: Can't list deployments after scaling client-go#734
• client-go/testing - disallow some subresource updates for pods, nodes, services #97937