Fix leaking goroutines in multiple integration tests #110604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
aojea
reviewed
Jun 15, 2022
Comment on lines
-50
to
-51
| controlPlaneConfig.GenericConfig.OpenAPIConfig = framework.DefaultOpenAPIConfig() | ||
| controlPlaneConfig.GenericConfig.OpenAPIV3Config = framework.DefaultOpenAPIV3Config() |
There was a problem hiding this comment.
don't you need to pass this to the StartTestServer() function
ModifyServerConfig: func(config *controlplane.Config) {
config.GenericConfig.OpenAPIConfig = framework.DefaultOpenAPIConfig()
There was a problem hiding this comment.
You don't - that's a default...
aojea
reviewed
Jun 15, 2022
| @@ -150,16 +142,14 @@ func TestPriorityLevelIsolation(t *testing.T) { | |||
| if (noxu1RequestCount/2) > noxu2RequestCount || (noxu2RequestCount/2) > noxu1RequestCount { | |||
| t.Errorf("imbalanced requests made by noxu1/2: (%d:%d)", noxu1RequestCount, noxu2RequestCount) | |||
| } | |||
|
|
|||
| t.Errorf("DUMP") | |||
wojtek-t
force-pushed
the
fix_leaking_goroutines_9
branch
from
5e9294a
to
6b59525
Compare
|
@aojea - PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #108483
Note to reviewer: I recommend reviewing commits one by one - they are all independent.
/kind cleanup
/priority important-longterm
/sig api-machinery