Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump konnectivity-client to 0.0.32 #110731

Merged
merged 1 commit into from Jun 23, 2022
Merged

Bump konnectivity-client to 0.0.32 #110731

merged 1 commit into from Jun 23, 2022

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Jun 22, 2022

What type of PR is this?

/kind feature

-->

What this PR does / why we need it:

Tag 0.0.32 includes an API change (kubernetes-sigs/apiserver-network-proxy#360) needed to continue improving tunnel context handling in kube-apiserver.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Partial progress toward kubernetes-sigs/apiserver-network-proxy#357

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from cheftako, cjcullen and a team June 22, 2022 20:22
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 22, 2022
@cheftako
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 22, 2022
@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
@jkh52
Copy link
Contributor Author

jkh52 commented Jun 22, 2022

/assign @thockin

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@jkh52
Copy link
Contributor Author

jkh52 commented Jun 23, 2022

Fixed merge conflicts (with #110724)

@jkh52
Copy link
Contributor Author

jkh52 commented Jun 23, 2022

/retest

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 23, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 23, 2022
@jkh52
Copy link
Contributor Author

jkh52 commented Jun 23, 2022

/cc @liggitt

liggitt
liggitt reviewed Jun 23, 2022
View reviewed changes
vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client.go
// close any channels remaining for these connections.
t.connsLock.Lock()
for _, conn := range t.conns {
close(conn.readCh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoisting question from #110019 (comment)

do we also need to send "" to conn.closeCh and close(conn.closeCh) like case client.PacketType_CLOSE_RSP does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, improving this inconsistency would at most help to unblock any goroutine calling conn.Close (and perhaps allow an error message like "tunnel is closing").

Overall kubernetes-sigs/apiserver-network-proxy#341 is a net improvement because it unblocks goroutines that call conn.Read (which block forever on readCh), and it doesn't seem any worse from conn.Close perspective.

So I think we don't need to block this PR on this question, and can take the code cleanup to the apiserver-network-proxy project.

@cheftako Please chime in if I'm wrong about anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@liggitt liggitt mentioned this pull request Jun 23, 2022
Closed
@liggitt
Copy link
Member

liggitt commented Jun 23, 2022

/approve

@liggitt
Copy link
Member

liggitt commented Jun 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 801bcfe into kubernetes:master Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cheftako cheftako Awaiting requested review from cheftako

@cjcullen cjcullen Awaiting requested review from cjcullen

Assignees

@cheftako cheftako

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jkh52 @cheftako @leilajal @liggitt @k8s-ci-robot @thockin