(kubectl events): Add integration tests #110766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
k8s-ci-robot
removed
needs-priority
|
/sig cli |
k8s-ci-robot
added
sig/cli
brianpursley
suggested changes
Jun 24, 2022
test/cmd/events.sh
Outdated
| # Post-condition: namespace 'test-jobs' is created. | ||
| kube::test::get_object_assert 'namespaces/test-events' "{{$id_field}}" 'test-events' | ||
|
|
||
| # Pre-condition: event does not exist for Cronjob/pi in test-events namespace |
There was a problem hiding this comment.
technically, this is using the -A flag, so it is not just checking in the test-events namespace. Is that OK? Or does the comment need to be changed?
There was a problem hiding this comment.
I changed the comment. We need to ensure that Cronjob/pi should not exist in any namespace.
ardaguclu
force-pushed
the
add-integration-for-events
branch
from
097bfa7
to
f8a8766
Compare
|
@brianpursley could you PTAL?. Thanks. |
This PR adds integration tests for `kubectl alpha events`
ardaguclu
force-pushed
the
add-integration-for-events
branch
from
f8a8766
to
f5af2d0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, brianpursley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds integration tests for
kubectl alpha eventsDoes this PR introduce a user-facing change?