Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:remove Redundant type conversion #110930

Merged
merged 1 commit into from Jul 13, 2022
Merged

fix:remove Redundant type conversion #110930

merged 1 commit into from Jul 13, 2022

Conversation

falser101
Copy link
Contributor

Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove Redundant type conversion

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 3, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: falser101 (6296b3ebfd904dc94c0b8aad2432a7f37d6bc795)

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @falser101!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @falser101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2022
@leilajal
Copy link
Contributor

leilajal commented Jul 7, 2022

/assign @DangerOnTheRanger
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2022
@DangerOnTheRanger
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2022
@DangerOnTheRanger
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2022
@falser101
Copy link
Contributor Author

/retest-required

/retest-required

@liggitt
Copy link
Member

liggitt commented Jul 12, 2022

can we drop the changes to the third_party/forked folders? we generally try to minimize changes to those dirs

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@falser101
Copy link
Contributor Author

falser101 commented Jul 12, 2022 •
edited

can we drop the changes to the third_party/forked folders? we generally try to minimize changes to those dirs

already dropped,please help review
@liggitt
@DangerOnTheRanger

@liggitt
Copy link
Member

liggitt commented Jul 12, 2022

thanks. squash to a single commit, then lgtm

@falser101
fix:remove Redundant type conversion
f07d8d3 
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
@falser101

This comment was marked as outdated.

Sign in to view
@falser101
Copy link
Contributor Author

falser101 commented Jul 13, 2022 •
edited

thanks. squash to a single commit, then lgtm

squashed
@liggitt
@DangerOnTheRanger

@falser101
Copy link
Contributor Author

/retest-required

/retest-required

1 similar comment
@falser101
Copy link
Contributor Author

/retest-required

/retest-required

@liggitt
Copy link
Member

liggitt commented Jul 13, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falser101, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit c813886 into kubernetes:master Jul 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 13, 2022
@falser101 falser101 deleted the fix/codeCleanUp branch July 14, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@DangerOnTheRanger DangerOnTheRanger

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@falser101 @k8s-ci-robot @leilajal @DangerOnTheRanger @liggitt