-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service port mutation test #110967
Add service port mutation test #110967
Conversation
@iXinqi: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @iXinqi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @jayunit100, may I have your review of this pr? I haven't tested it yet. Just want to make sure the test case meets our need. If it looks good to you, I'll go ahead and test it. Thanks. |
hi xinqi - just compiled and tested it , appears to be working mostly (tested the negative case where my cluster was broke, and the test failed :)) lets make sure it passes other e2es... /ok-to-test then we can get a broader review on it. can you add a little more of a comment about where we saw this (i.e. we saw the original regression in alternate kube proxies, but its still a good upstream regression test to have in place) |
/sig network |
Xinqi can you check into those failures ? |
f8d29ac
to
07bf47d
Compare
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
lgtm. some nits to clean the code and stop carrying with the defer for cleanups on tests |
07bf47d
to
b78a106
Compare
Thanks for reviewing. I've already removed the defer functions. |
b78a106
to
d6f7299
Compare
Hi @aojea and @jayunit100, may I have your approval to merge this pr? Thanks! |
great work, /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, iXinqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
What type of PR is this?
What this PR does / why we need it:
Adding service port mutation test. More specifically:
Which issue(s) this PR fixes:
Fixes #110918
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: