Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service port mutation test #110967

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

iXinqi
Copy link

@iXinqi iXinqi commented Jul 5, 2022

What type of PR is this?

What this PR does / why we need it:

Adding service port mutation test. More specifically:

  • Create a service
  • Confirm that the service works
  • Edit the service by adding a new port to it
  • Confirm both ports work
  • Delete the added port
  • Confirm these still work

Which issue(s) this PR fixes:

Fixes #110918

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

@iXinqi: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @iXinqi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 5, 2022
@iXinqi
Copy link
Author

iXinqi commented Jul 5, 2022

Hi @jayunit100, may I have your review of this pr? I haven't tested it yet. Just want to make sure the test case meets our need. If it looks good to you, I'll go ahead and test it. Thanks.

@jayunit100
Copy link
Member

jayunit100 commented Jul 6, 2022

hi xinqi - just compiled and tested it , appears to be working mostly (tested the negative case where my cluster was broke, and the test failed :))

lets make sure it passes other e2es...

/ok-to-test

then we can get a broader review on it. can you add a little more of a comment about where we saw this (i.e. we saw the original regression in alternate kube proxies, but its still a good upstream regression test to have in place)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@jayunit100
Copy link
Member

/sig network

@jayunit100
Copy link
Member

Xinqi can you check into those failures ?

@iXinqi iXinqi force-pushed the lxinqi/port-mutation-test branch from f8d29ac to 07bf47d Compare July 7, 2022 18:30
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2022
@iXinqi iXinqi marked this pull request as ready for review July 7, 2022 18:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2022
@iXinqi
Copy link
Author

iXinqi commented Jul 7, 2022

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@iXinqi
Copy link
Author

iXinqi commented Jul 8, 2022

/test pull-kubernetes-e2e-gce-ubuntu-containerd

test/e2e/network/service.go Outdated Show resolved Hide resolved
test/e2e/network/service.go Outdated Show resolved Hide resolved
@aojea
Copy link
Member

aojea commented Jul 10, 2022

lgtm. some nits to clean the code and stop carrying with the defer for cleanups on tests

@iXinqi iXinqi force-pushed the lxinqi/port-mutation-test branch from 07bf47d to b78a106 Compare July 11, 2022 18:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2022
@iXinqi
Copy link
Author

iXinqi commented Jul 11, 2022

lgtm. some nits to clean the code and stop carrying with the defer for cleanups on tests

Thanks for reviewing. I've already removed the defer functions.

@iXinqi iXinqi force-pushed the lxinqi/port-mutation-test branch from b78a106 to d6f7299 Compare July 11, 2022 18:45
@iXinqi
Copy link
Author

iXinqi commented Jul 12, 2022

Hi @aojea and @jayunit100, may I have your approval to merge this pr? Thanks!

@aojea
Copy link
Member

aojea commented Jul 21, 2022

great work,
Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, iXinqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@aojea
Copy link
Member

aojea commented Jul 21, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit bce7f34 into kubernetes:master Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Port mutation tests
4 participants