New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor taint_manager to do not use getPod and getNode stubs #111084
Refactor taint_manager to do not use getPod and getNode stubs #111084
Conversation
Hi @mimowo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9b80f47
to
345c1ea
Compare
/ok-to-test |
5652a7d
to
1ad32b4
Compare
/retest |
1ad32b4
to
8f6c5bd
Compare
cb996ff
to
4ec8cf0
Compare
/lgtm |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR refactors taint_manager to eliminate the getPod and getNode stubs. It will allow easier adding or unit tests.
It is a preparatory code change before
Append new pod conditions when deleting pods to indicate the reason for pod deletion #110959.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: