Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test for pkg/kubelet/types/ func GetPodStartTime() #111139

Merged
merged 1 commit into from Jul 27, 2022
Merged

add unit test for pkg/kubelet/types/ func GetPodStartTime() #111139

merged 1 commit into from Jul 27, 2022

Conversation

zhoumingcheng
Copy link
Contributor

Signed-off-by: zhoumingcheng zhoumingcheng@beyondcent.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve test coverage

Add unit tests for pkg/kubelet/types/ func GetPodStartTime()

Run test coverage command:

go test -cover ./pkg/scheduler/util/

Befor:

ok      k8s.io/kubernetes/pkg/scheduler/util    0.024s  coverage: 80.9% of statements

After:

ok      k8s.io/kubernetes/pkg/scheduler/util    0.061s  coverage: 85.3% of statements

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Thank you！

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

@zhoumingcheng: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @zhoumingcheng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2022
@kerthcet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2022
@zhoumingcheng
Copy link
Contributor Author

/retest

@zhoumingcheng
Copy link
Contributor Author

/assign @ahg-g

kerthcet
kerthcet reviewed Jul 15, 2022
View reviewed changes
pkg/scheduler/util/utils_test.go Outdated Show resolved Hide resolved
pkg/scheduler/util/utils_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2022
@zhoumingcheng
Copy link
Contributor Author

/assign @ahg-g

kerthcet
kerthcet reviewed Jul 21, 2022
View reviewed changes
pkg/scheduler/util/utils_test.go Outdated Show resolved Hide resolved
pkg/scheduler/util/utils_test.go Outdated Show resolved Hide resolved
ahg-g
ahg-g reviewed Jul 25, 2022
View reviewed changes
pkg/scheduler/util/utils_test.go Outdated
expectedStartTime: &metav1.Time{Time: currentTime.Add(-time.Second)},
},
{
name: "Got earliest pod start time",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Got earliest pod start time",
name: "Pod with earliest start time last in the list",

pkg/scheduler/util/utils_test.go Outdated
expectedStartTime: &metav1.Time{Time: currentTime},
},
{
name: "Got earliest pod start time",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Got earliest pod start time",
name: "Pod with earliest start time first in the list",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@zhoumingcheng
Copy link
Contributor Author

/retest

@zhoumingcheng
add unit test for pkg/kubelet/types/ func GetPodStartTime()
9b6f880 
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
@zhoumingcheng
Copy link
Contributor Author

/retest

2 similar comments
@zhoumingcheng
Copy link
Contributor Author

/retest

@zhoumingcheng
Copy link
Contributor Author

/retest

@ahg-g
Copy link
Member

ahg-g commented Jul 27, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, zhoumingcheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4cd1c80 into kubernetes:master Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

@ahg-g ahg-g ahg-g left review comments

@denkensk denkensk Awaiting requested review from denkensk

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhoumingcheng @k8s-ci-robot @kerthcet @ahg-g @k8s-triage-robot