Remove estimateMinSizeJSON calls for CEL

[DangerOnTheRanger]

What type of PR is this?

/kind feature

What this PR does / why we need it:

estimateMinSizeJSON is a function that is used to estimate the minimum valid size for a given schema node when serialized into JSON (this is used in turn to calculate how many values things like maps and arrays can have). The function works by walking through everything below the schema node it was given, though since SchemaDeclType (which is what calls estimateMinSizeJSON) is already walking the entire schema and calls estimateMinSizeJSON for all arrays/maps, this results in a lot of redundant estimateMinSizeJSON calls. This PR removes the need entirely for estimateMinSizeJSON by adding a MinSerializedSize attribute to DeclTypes instead.

The below two tables show the performance gained from this change; the tables were generated with the benchmark included in this branch (the estimateMinSizeJSON table used the benchmark patched onto master), with the depth parameter passed to genNestedSchema adjusted as per the values in the n column. All runs were performed on a 16-core Intel Xeon clocked at 2.3Ghz with 66GB of RAM.

with estimateMinSizeJSON

n (schema depth)	ns/op
1	538
5	10275
10	385079
15	22950231

with MinSerializedSize

n (schema depth)	ns/op
1	482
5	2274
10	4863
15	6750

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[cici37]

Would you mind try with existing benchmark test(or write your own if needed) to show the performance different?

[liggitt]

/assign @jpbetz
for initial review

[jpbetz]

Per offline discussion, we should close this in favor of #110135 but still need a PR to optimize the minSize calculations performed by

kubernetes/staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model/schemas.go

Line 246 in 5b92e46

func estimateMinSizeJSON(s *schema.Structural) int64 {

[leilajal]

/triage accepted

[jpbetz]

Great to see the code for this change fell out roughly as I had hoped. It's a nice simplification and optimization combined into one change.

[jpbetz]

/lgtm
/assign @liggitt for approval

[k8s-ci-robot]

@jpbetz: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/lgtm
/assign @liggitt for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

I love this cleanup... putting the size computation in the recursive construction we were already doing makes a ton of sense.

[DangerOnTheRanger]

/test pull-kubernetes-e2e-gce-ubuntu-containerd

[DangerOnTheRanger]

/test pull-kubernetes-e2e-gce-ubuntu-containerd

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DangerOnTheRanger, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DangerOnTheRanger]

/retest