Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandleError of updateStatusIfNeeded in func reconcileAutoscaler #111170

Merged
merged 1 commit into from Aug 30, 2022
Merged

HandleError of updateStatusIfNeeded in func reconcileAutoscaler #111170

merged 1 commit into from Aug 30, 2022

Conversation

ping035627
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
“updateStatusIfNeeded” may fail in func (a *HorizontalController) reconcileAutoscaler. We should HandleError.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/release-note-none
/priority backlog
/triage accepted

@ping035627
HandleError of updateStatusIfNeeded in func reconcileAutoscaler
565d60f 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 15, 2022
@ping035627
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 15, 2022
@ping035627
Copy link
Contributor Author

/test pull-kubernetes-unit

3 similar comments
@ping035627
Copy link
Contributor Author

/test pull-kubernetes-unit

@ping035627
Copy link
Contributor Author

/test pull-kubernetes-unit

@249043822
Copy link
Member

/test pull-kubernetes-unit

@249043822
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@249043822
Copy link
Member

/assign @josephburnett @mwielgus

@josephburnett
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephburnett, ping035627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 239a19e into kubernetes:master Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephburnett josephburnett Awaiting requested review from josephburnett

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@josephburnett josephburnett

@mwielgus mwielgus

@249043822 249043822

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ping035627 @249043822 @josephburnett @k8s-ci-robot @mwielgus