New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding value attribute to get the value of zone property as per the u… #111342
Adding value attribute to get the value of zone property as per the u… #111342
Conversation
…pdate in output of gcloud info command https://cloud.google.com/sdk/docs/release-notes#miscellaneous
Hi @ndixita. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@ndixita: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/triage accepted
/priority important-soon
/lgtm
/assign @dims
I've been carrying this patch locally for a few weeks - thanks for opening the PR!
Was holding off opening it because I wasn't sure how widely it was rolled out
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, endocrimes, ndixita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/sig node
What this PR does / why we need it:
As per https://cloud.google.com/sdk/docs/release-notes#miscellaneous, gcloud changed their output for 'gcloud info' command and requires value attribute i.e.".value" to get the value of a property. Hence, this PR is appending ".value" to get the value of zone being set in the property file.
Output of gcloud info command without using value attribute for zone property:
$ gcloud info --format='value(config.properties.compute.zone)'
source={'name': 'PROPERTY_FILE', 'value': 'property file'};value=us-central1-c
Output of gcloud info command with value attribute for zone property:
$ gcloud info --format='value(config.properties.compute.zone.value)'
us-central1-c
Special notes for your reviewer:
Does this PR introduce a user-facing change?