Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fallocate with dd in e2e tests #111369

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

uablrek
Copy link
Contributor

@uablrek uablrek commented Jul 23, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

K8s does not require support for fallocate in container fs'es, so neither should e2e tests. This PR replaces fallocate with the more primitive, but always working, dd command.

Which issue(s) this PR fixes:

Fixes #111368

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2022
@k8s-ci-robot
Copy link
Contributor

@uablrek: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2022
@aojea
Copy link
Member

aojea commented Jul 23, 2022

Learning something new ☺️
https://antipaucity.com/2017/08/31/fallocate-vs-dd-for-swap-file-creation/#.Ytwo7eyxWdM

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2022
@aojea
Copy link
Member

aojea commented Jul 23, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, uablrek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5f6b60b into kubernetes:master Jul 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 23, 2022
@uablrek
Copy link
Contributor Author

uablrek commented Jul 23, 2022

Learning something new relaxed https://antipaucity.com/2017/08/31/fallocate-vs-dd-for-swap-file-creation/#.Ytwo7eyxWdM

In the neighborhood; if a sparse file is acceptable then use;

~ > truncate -s 100G file
~ > ls -lsh file
0 -rw-r--r-- 1 uablrek lgekman 100G Jul 23 20:05 file

This is the best as base for a file system image, but not for a swapfile or in this test where you really must occupy disk space.

And since the file in the test-case is just 10M the gain of using fallocate is minimal.

@uablrek uablrek deleted the remove-fallocate branch July 23, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2e tests require support for fallocate while K8s does not
3 participants