-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fallocate with dd in e2e tests #111369
Conversation
@uablrek: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Learning something new /lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, uablrek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the neighborhood; if a sparse file is acceptable then use;
This is the best as base for a file system image, but not for a swapfile or in this test where you really must occupy disk space. And since the file in the test-case is just 10M the gain of using |
What type of PR is this?
/kind bug
What this PR does / why we need it:
K8s does not require support for
fallocate
in container fs'es, so neither should e2e tests. This PR replacesfallocate
with the more primitive, but always working,dd
command.Which issue(s) this PR fixes:
Fixes #111368
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: