Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow --force and --prune in client-side apply #111374

Merged
merged 2 commits into from
Jul 25, 2022
Merged

disallow --force and --prune in client-side apply #111374

merged 2 commits into from
Jul 25, 2022

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jul 24, 2022 •
edited

  • Disallow --force and --prune flags in client-side apply.
  • Adds unit tests for apply args.

Fixes kubernetes/kubectl#1239 (part 1)

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2022
@seans3
Copy link
Contributor Author

seans3 commented Jul 24, 2022

/sig cli
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl labels Jul 24, 2022
@ardaguclu
Copy link
Member

This lgtm but unit tests need goftm

@pacoxu
Copy link
Member

pacoxu commented Jul 25, 2022

LGTM

@pacoxu
Copy link
Member

pacoxu commented Jul 25, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2022
@pacoxu pacoxu added this to Needs review in SIG CLI Jul 25, 2022
@ardaguclu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@seans3
Copy link
Contributor Author

seans3 commented Jul 25, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit c633f71 into kubernetes:master Jul 25, 2022
SIG CLI automation moved this from Needs review to Done Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland Awaiting requested review from dougsland

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Weird behaviour with --prune when updating immutable labels with --force
4 participants
@seans3 @k8s-ci-robot @ardaguclu @pacoxu