New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 'running_managed_controllers' for KCM/CCM controllers: routes, services and cloud-node #111462
Conversation
/assign @cheftako |
32b0628
to
5c02928
Compare
/test pull-kubernetes-e2e-kind |
/remove-sig api-machinery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not super familiar with this code, but this generally makes sense to me
LGTM
/cc @logicalhan Do we need to do anything like mark these metrics as alpha/beta? |
/lgtm |
It looks like these are already marked as |
5c02928
to
0874975
Compare
Rebased due to merge conflict with #111538 - rename controller variable. |
/assign @mikedanese Could you approve for |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, jprzychodzen, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables
running_managed_controllers
for controllers running inside KCM and CCM.This metric support HA migration described in KEP-2436
Which issue(s) this PR fixes:
It doesn't fix, but is a part of #111029
Special notes for your reviewer:
First PR is already merged. See #111033.
This is a second PR in a series. There will be upcoming PR to handle nodeipam controller separately.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider