Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test flake: Probing container should mark readiness on pods to false... #111578

Closed
brianpursley opened this issue Jul 30, 2022 · 9 comments · Fixed by #111741
Closed

e2e test flake: Probing container should mark readiness on pods to false... #111578

brianpursley opened this issue Jul 30, 2022 · 9 comments · Fixed by #111741
Assignees
@249043822
Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@brianpursley
Copy link
Member

brianpursley commented Jul 30, 2022 •
edited

Which jobs are flaking?

pull-kubernetes-e2e-kind-ipv6

Which tests are flaking?

Failure cluster 2b82bf704961f0af177d

Kubernetes e2e suite.[It] [sig-node] Probing container should mark readiness on pods to false and disable liveness probes while pod is in progress of terminating

See also, possibly related:
Kubernetes e2e suite.[It] [sig-node] Probing container should mark readiness on pods to false while pod is in progress of terminating when a pod has a readiness probe

Since when has it been flaking?

Not sure. At least as of July 27, 2022, but probably earlier than that.

Testgrid link

https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-e2e-kind-ipv6

Reason for failure (if possible)

No response

Anything else we need to know?

image

Relevant SIG(s)

/sig node
@brianpursley brianpursley added the kind/flake Categorizes issue or PR as related to a flaky test. label Jul 30, 2022
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 30, 2022
@k8s-ci-robot
Copy link
Contributor

@brianpursley: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 30, 2022
@brianpursley
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 30, 2022
@249043822
Copy link
Member

/assign
we should use listwatch to monitor pod status changes accurately, this interval 2s may lose pod change and cause the test failure

@aojea
Copy link
Member

aojea commented Aug 5, 2022

/assign we should use listwatch to monitor pod status changes accurately, this interval 2s may lose pod change and cause the test failure

we did the same recently in another test, didn't we?
I can't find the PR

@249043822
Copy link
Member

249043822 commented Aug 5, 2022 •
edited

@aojea sorry, i have not committed yet. do you plan to fix this test again? if so, I can unassign

@aojea
Copy link
Member

aojea commented Aug 5, 2022 •
edited

@aojea sorry, i have not committed yet. do you plan to fix this test again? if so, I can unassign

he, no sorry for the confusion, I thought you were the one that fixed it, maybe it was @pacoxu ?
There was one e2e that was flake and was solved using a listwatch instead of polling it every few seconds, I was trying to find the PR to show you , in case it can give you some idea ... please go ahead and fix it :)

@pacoxu
Copy link
Member

pacoxu commented Aug 5, 2022

#108958 this one?

@249043822 249043822 mentioned this issue Aug 8, 2022
Merged
@aojea
Copy link
Member

aojea commented Aug 8, 2022

#108958 this one?

yeah, so my memory was good then, I've identified the right author 😄

@249043822
Copy link
Member

/assign we should use listwatch to monitor pod status changes accurately, this interval 2s may lose pod change and cause the test failure

we did the same recently in another test, didn't we? I can't find the PR

I didn't understand what you said at first, but now I understand 😄

@alculquicondor alculquicondor mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@249043822 249043822

Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:e2e test flake: Probing container should mark readiness on pods to false... 249043822/kubernetes
5 participants
@pacoxu @brianpursley @aojea @249043822 @k8s-ci-robot