Remove some unused functions

[thockin]

We really should have a tool that check for this on internal (unsupported for external users, not staging/...) pkgs.

I found these by accident - I guarantee there are more.

/kind cleanup

NONE

[k8s-ci-robot]

@thockin: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

why the linter unused is not flagging them?

kubernetes/.golangci.yaml

Line 28 in ea21947

- unused

it seems there is a private copy here

kubernetes/staging/src/k8s.io/component-helpers/scheduling/corev1/nodeaffinity/nodeaffinity.go

Lines 203 to 205 in ea21947

	// nodeSelectorRequirementsAsSelector converts the []NodeSelectorRequirement api type into a struct that implements
	// labels.Selector.
	func nodeSelectorRequirementsAsSelector(nsm []v1.NodeSelectorRequirement, path *field.Path) (labels.Selector, []error) {

[aojea]

/lgtm

double checked

$ grep -r NodeSelectorRequirementsAsSelector
pkg/apis/core/helper/helpers_test.go:func TestNodeSelectorRequirementsAsSelector(t *testing.T) {
pkg/apis/core/helper/helpers_test.go:           out, err := NodeSelectorRequirementsAsSelector(tc.in)
pkg/apis/core/helper/helpers.go:// NodeSelectorRequirementsAsSelector converts the []NodeSelectorRequirement core type into a struct that implements
pkg/apis/core/helper/helpers.go:func NodeSelectorRequirementsAsSelector(nsm []core.NodeSelectorRequirement) (labels.Selector, error) {
staging/src/k8s.io/component-helpers/scheduling/corev1/nodeaffinity/nodeaffinity_test.go:func TestNodeSelectorRequirementsAsSelector(t *testing.T) {
$ grep -r NodeSelectorRequirementsAsFieldSelector
pkg/apis/core/helper/helpers.go:// NodeSelectorRequirementsAsFieldSelector converts the []NodeSelectorRequirement core type into a struct that implements
pkg/apis/core/helper/helpers.go:func NodeSelectorRequirementsAsFieldSelector(nsm []core.NodeSelectorRequirement) (fields.Selector, error) {

[Abirdcfly]

Let me try to explain, I'm not very familiar with https://github.com/dominikh/go-tools, please correct me if I'm wrong.

why the linter unused is not flagging them?

Because this pr deleted function is an exported function.

The linter unused uses internally is https://github.com/dominikh/go-tools/blob/master/unused/unused.go, It has some internal rules, such as treating the exported functions as having used, see https://github.com/dominikh/go-tools/blob/14865dd2a6230e8794e7a91ddcab515999bd50c6/unused/unused.go#L48-L154 for full description.

it seems there is a private copy here

There is something not quite the same, at least one more function parameter in private copy.

We really should have a tool that check for this on internal (unsupported for external users, not staging/...) pkgs.

Through my quick search, there doesn't seem to be such a tool readily available at the moment.

BTW, are we sure we don't guarantee the compatibility of the exported functions in the non-staging folder?

[thockin]

non-staging is effectively internal and we DO NOT make API guarantees there. We just can't.

[thockin]

It would be nice to have a tool that found "likely candidates" and let humans verify later.

[Abirdcfly]

Create #111666 for discussion