Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spec.template.spec.restartPolicy description #111856

Merged
merged 1 commit into from Feb 28, 2023
Merged

Improve spec.template.spec.restartPolicy description #111856

merged 1 commit into from Feb 28, 2023

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Aug 15, 2022 •
edited by liggitt

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Improve spec.template.spec.restartPolicy description to avoid user misunderstanding of usage methods.

Which issue(s) this PR fixes:

Fixes #111829

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 15 07:35:38 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 15, 2022
@mengjiao-liu
Copy link
Member Author

Wait for 1.25 Code Freeze to end.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from 174db23 to 37482cf Compare August 15, 2022 09:09
@fedebongio
Copy link
Contributor

/sig apps
/triage accepted
/help

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2022
@mengjiao-liu
Copy link
Member Author

Due to a recent arm injury, this PR has been delayed and is expected to be updated in 10 days.

@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from 37482cf to 62c0263 Compare September 14, 2022 08:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch 3 times, most recently from ae61225 to 6c441af Compare September 15, 2022 02:57
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from 6c441af to 60228df Compare September 26, 2022 04:42
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@dims
Copy link
Member

dims commented Dec 12, 2022

If you still need this PR then please rebase, if not, please close the PR

@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from 60228df to e1dfb45 Compare February 22, 2023 06:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@mengjiao-liu
Copy link
Member Author

Rebased.

@mengjiao-liu mengjiao-liu requested review from liggitt and removed request for mikedanese and liggitt February 22, 2023 06:46
@mengjiao-liu
Copy link
Member Author

/retest

liggitt
liggitt reviewed Feb 22, 2023
View reviewed changes
pkg/apis/apps/types.go Outdated Show resolved Hide resolved
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from e1dfb45 to c4bc699 Compare February 23, 2023 06:58
liggitt
liggitt reviewed Feb 24, 2023
View reviewed changes
staging/src/k8s.io/api/apps/v1beta1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/apps/v1beta2/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/apps/v1beta2/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/batch/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/batch/v1/types.go Outdated Show resolved Hide resolved
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from c4bc699 to 47ded76 Compare February 27, 2023 02:57
@mengjiao-liu mengjiao-liu force-pushed the improve-podSpec.restartPpolicy-description branch from 47ded76 to 81aefe5 Compare February 27, 2023 06:26
@liggitt
Copy link
Member

liggitt commented Feb 27, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ba19127dd80c784695d3345f9a1561f6e6ef325

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@mengjiao-liu
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 35f0507 into kubernetes:master Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
6 participants
@mengjiao-liu @k8s-ci-robot @fedebongio @dims @liggitt @k8s-triage-robot