-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not correct annotations with node.Spec.Unschedulable #111864
Remove not correct annotations with node.Spec.Unschedulable #111864
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 16 01:36:42 UTC 2022. |
@kerthcet: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -68,7 +68,6 @@ func (pl *NodeUnschedulable) Filter(ctx context.Context, _ *framework.CycleState | |||
Key: v1.TaintNodeUnschedulable, | |||
Effect: v1.TaintEffectNoSchedule, | |||
}) | |||
// TODO (k82cn): deprecates `node.Spec.Unschedulable` in 1.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc, this was deferred for some reasons, I am not sure remove this is the right thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments before #84266 (comment)
/assign @Huang-Wei PTAL |
@kerthcet: GitHub didn't allow me to assign the following users: PTAL. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind cleanup
/sig scheduling
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We won't remove fields from a given version, so we can't deprecate this until we have a v2 api version.
Prefer to remove the comments directly.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: