refactor: move attachdetach controller param validation ahead

[pandaamanda]

Code cleanup:

1. move attachdetach controller param attach-detach-reconcile-sync-period validation ahead.
2. add fucntion validateCIDRs to eliminate duplicated code.

NONE

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 18 07:40:11 UTC 2022.

[pandaamanda]

/kind cleanup

[leilajal]

/assign @DangerOnTheRanger
/triage accepted

[DangerOnTheRanger]

/lgtm

[pandaamanda]

/assign @sttts

[sttts]

Is this unit testable?

[pandaamanda]

Is this unit testable?

Tks.
No logic changed, should we add a unit test?

[sttts]

No logic changed

How do you know? :)

[pandaamanda]

No logic changed

How do you know? :)

IMO. The change is just code place changed, not related logic. so we should add a ut for param validation or function validateCIDRs or both?

[sttts]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pandaamanda, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kube-controller-manager/OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest