Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression test for exponential recursion bug on CRDs #111912

Merged
merged 1 commit into from
Aug 24, 2022
Merged

regression test for exponential recursion bug on CRDs #111912

merged 1 commit into from
Aug 24, 2022

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 18, 2022

/kind regression

Special notes for your reviewer:

Regression test for bug #109099

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 18 13:40:40 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 18, 2022
@aojea aojea mentioned this pull request Aug 18, 2022
Closed
@aojea
Copy link
Member Author

aojea commented Aug 18, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2022
@aojea
Copy link
Member Author

aojea commented Aug 18, 2022

/assign @liggitt
/hold

the test flakes with

    crd_regression_test.go:131: Failed to create custom resource: the server could not find the requested resource

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@aojea aojea mentioned this pull request Aug 18, 2022
Merged
apelisse
apelisse reviewed Aug 18, 2022
View reviewed changes
test/integration/apiserver/crd_regression_test.go
)

// Regression test for https://issues.k8s.io/109099
func TestCRDExponentialRecursionBug(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we turn that into a benchmark? It's unclear since I don't think benchmarks are run or that we have a good way to see the results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I've seen benchmarks used in k/k is adding the results to the commit description or as a comment, but AFAIK they don't run on CI , I remember this was discussed but don't know what was the conclusion, maybe @BenTheElder remember something more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're automatically running some benchmarks in the smd repository but I don't think we have the same thing in k/k.

https://testgrid.k8s.io/sig-api-machinery-structured-merge-diff#ci-benchmark&graph-metrics=avg%20op%20duration%20(ns%2Fop)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't run them in K/K historically because we had major noisy neighbor problems in CI.

it still may be worth checking in benchmarks to avoid needing to reimplement for future sensitive changes / debugging?

it may also not be a big issue now if running in sig-k8s-infra cluster where we require jobs to at least set cpu/memory requests now (though disk I/O noise is still unavoidable #3595)

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2022
@aojea aojea force-pushed the crd_recursion_regression_test branch from 6419315 to 8d7264f Compare August 19, 2022 07:43
@aojea
Copy link
Member Author

aojea commented Aug 19, 2022

/hold cancel
/assign @apelisse

This is ok now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2022
@liggitt
Copy link
Member

liggitt commented Aug 19, 2022

/lgtm

non-blocking for 1.25, can merge to 1.26

@liggitt liggitt added this to the v1.26 milestone Aug 19, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@liggitt liggitt mentioned this pull request Aug 19, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit 22cb7ac into kubernetes:master Aug 24, 2022
@aojea aojea mentioned this pull request Aug 29, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 7, 2022
@k8s-ci-robot
Merge pull request #112099 from aojea/automated-cherry-pick-of-#11191…
bbdaa57 
…2-upstream-release-1.25

Automated cherry pick of #111912: regression test for exponential recursion bug on CRDs
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@apelisse apelisse apelisse left review comments

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@liggitt liggitt

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aojea @k8s-ci-robot @leilajal @liggitt @BenTheElder @apelisse