Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong status returned from RunPreFilterPlugins #112029

Merged
merged 1 commit into from Aug 26, 2022
Merged

Fix the wrong status returned from RunPreFilterPlugins #112029

merged 1 commit into from Aug 26, 2022

Conversation

chendave
Copy link
Member

@chendave chendave commented Aug 25, 2022 •
edited

event msg will be impacted due to the wrong status is returned.
e.g.

Warning  FailedScheduling ... running PreFilter plugin "PodTopologySpread": %!!(MISSING)w(<nil>)

/kind bug

Signed-off-by: Dave Chen dave.chen@arm.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

@chendave: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 25, 2022
sanposhiho
sanposhiho reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

pkg/scheduler/framework/runtime/framework_test.go Outdated

plugins := &config.Plugins{PreFilter: config.PluginSet{Enabled: []config.Plugin{{Name: preFilterPluginName}}}}

t.Run("TestPreFilterPluginStatus", func(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say you don't need to use subtest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this testcase to expand a little bit to cover more scenario of RunPreFilterPlugins, but for now, yes, it's only used to test the fixing of the bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If considering the future expansion, we can implement it as table-driven tests with only one table for now.
I left it up to you to decide; implement as table-driven tests or as a single test as it is now. Either way seems fine to me.

@chendave
Copy link
Member Author

/priority important-soon

/assign @sanposhiho @ahg-g

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 26, 2022
@chendave
Fix the wrong status returned from RunPreFilterPlugins
8a288d6 
event msg will be impacted due to the wrong status is returned.
e.g.

Warning  FailedScheduling ... running PreFilter plugin "PodTopologySpread": %!!(MISSING)w(<nil>)

Signed-off-by: Dave Chen <dave.chen@arm.com>
sanposhiho
sanposhiho reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@ahg-g
Copy link
Member

ahg-g commented Aug 26, 2022

/approve

Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, chendave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit dbe3ac7 into kubernetes:master Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 26, 2022
@chendave chendave deleted the fix_status branch August 29, 2022 01:44
This was referenced Sep 21, 2022
Closed
Closed
@ingvagabund ingvagabund mentioned this pull request Jun 12, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 7, 2023
@k8s-ci-robot
Merge pull request #118618 from ingvagabund/automated-cherry-pick-of-…
9347e55 
…#112029-upstream-release-1.25

Automated cherry pick of #112029: Fix the wrong status returned from `RunPreFilterPlugins`
ZiMengSheng pushed a commit to ZiMengSheng/koordinator that referenced this pull request Apr 26, 2024
@eahydra
use internal client-go and kubernetes to solve the upstream bugs
f5677a5 
fix kubernetes/kubernetes#112334
fix kubernetes/kubernetes#112029

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@ahg-g ahg-g

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chendave @k8s-ci-robot @ahg-g @sanposhiho