Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update changelog kube-proxy distroless based on feedback #112049

Merged
merged 2 commits into from Aug 26, 2022
Merged

update changelog kube-proxy distroless based on feedback #112049

merged 2 commits into from Aug 26, 2022

Conversation

csantanapr
Copy link
Member

@csantanapr csantanapr commented Aug 26, 2022 •
edited

update changelog based on feedback

/kind cleanup
/kind documentation
/sig release

NONE

@csantanapr
update changelog based on feedback
612f57b 
Signed-off-by: Carlos Santana <csantana23@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@csantanapr
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 26, 2022
dims
dims reviewed Aug 26, 2022
View reviewed changes
CHANGELOG/CHANGELOG-1.25.md Outdated Show resolved Hide resolved
@csantanapr @dims
Update CHANGELOG/CHANGELOG-1.25.md
fa577b8 
Co-authored-by: Davanum Srinivas <davanum@gmail.com>
@dims
Copy link
Member

dims commented Aug 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@cici37
Copy link
Contributor

cici37 commented Aug 26, 2022

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot merged commit 3884964 into kubernetes:master Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 26, 2022
@puerco
Copy link
Member

puerco commented Aug 26, 2022

@csantanapr can you cherry-pick this to the release-1.25 branch to even the documents? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@puerco puerco Awaiting requested review from puerco

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@dims dims

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@csantanapr @k8s-ci-robot @dims @cici37 @puerco