Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync website change #112053

Merged
merged 1 commit into from Nov 3, 2022
Merged

sync website change #112053

merged 1 commit into from Nov 3, 2022

Conversation

helen-frank
Copy link
Contributor

…nsufficient.

What type of PR is this?

/kind documentation

What this PR does / why we need it:

sync website change

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

According to the context. The word should be "underspecified" meaning "insufficient"
But, According https://github.com/kubernetes/website/pull/2991/files，I think a change like that is more reasonable.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @helen-frank. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2022
@pacoxu pacoxu added this to Triage in SIG Node PR Triage Aug 31, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Waiting on Author in SIG Node PR Triage Sep 29, 2022
@SergeyKanzhelev
Copy link
Member

See #3015

This whole functionality got removed from kubelet. So please remove the entire statement

@helen-frank helen-frank closed this Oct 1, 2022
SIG Node PR Triage automation moved this from Waiting on Author to Done Oct 1, 2022
@helen-frank helen-frank reopened this Oct 1, 2022
SIG Node PR Triage automation moved this from Done to Triage Oct 1, 2022
@helen-frank helen-frank force-pushed the fix/patchKubeletLongDescription branch from 710f78c to dd0cfb3 Compare October 2, 2022 10:56
@helen-frank helen-frank requested review from SergeyKanzhelev and removed request for mrunalp and matthyx October 2, 2022 10:57
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Waiting on Author in SIG Node PR Triage Oct 3, 2022
@SergeyKanzhelev
Copy link
Member

/triage accepted
/priority backlog

I will ok-to-test once comments are addressed to not run tests unnecessary

@helen-frank helen-frank force-pushed the fix/patchKubeletLongDescription branch from dd0cfb3 to a57fa74 Compare October 4, 2022 04:12
@helen-frank
Copy link
Contributor Author

Also can you please send similar PRs to website repository so I can comment on it too. Thank you!

Thank you very much for giving me this opportunity to participate in the open source community work. I will mention some higher quality pr in the future.

SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Oct 4, 2022
@helen-frank
Copy link
Contributor Author

/assign @yujuhong

@helen-frank
Remove HTTP Server support for pushing pods onto the kubelet kubernet…
008dc87 
…es#3015

Signed-off-by: helen <helenfrank@protonmail.com>
Signed-off-by: helen <haitao.zhang@daocloud.io>
@helen-frank helen-frank force-pushed the fix/patchKubeletLongDescription branch from a57fa74 to 008dc87 Compare October 18, 2022 14:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2022
@helen-frank
Copy link
Contributor Author

/cc @yujuhong

@helen-frank
Copy link
Contributor Author

/retest

@helen-frank helen-frank mentioned this pull request Oct 20, 2022
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helen-frank, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Nov 1, 2022
@dims
Copy link
Member

dims commented Nov 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022
@helen-frank
Copy link
Contributor Author

/retest

1 similar comment
@pacoxu
Copy link
Member

pacoxu commented Nov 3, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit a091b01 into kubernetes:master Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
@helen-frank helen-frank deleted the fix/patchKubeletLongDescription branch November 20, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@dims dims

@SergeyKanzhelev SergeyKanzhelev

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@helen-frank @k8s-ci-robot @SergeyKanzhelev @dims @pacoxu @mrunalp @yujuhong