Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dryrun cleanup #112064

Merged
merged 1 commit into from Aug 27, 2022
Merged

Dryrun cleanup #112064

merged 1 commit into from Aug 27, 2022

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 26, 2022

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 26, 2022
@aojea
Copy link
Member Author

aojea commented Aug 26, 2022

/assign @apelisse @liggitt

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2022
@aojea
Copy link
Member Author

aojea commented Aug 26, 2022

hmm, how are we doing on terms of flakes?

https://storage.googleapis.com/k8s-triage/index.html?ci=0&pr=1

I start to see random and unrelated test failures

@aojea
Copy link
Member Author

aojea commented Aug 26, 2022

the apiserver fails to start here pull-kubernetes-e2e-gce-alpha-features that may be easily related, there are no apiserver logs though .... before start the digging @liggitt do you have any idea from the top of your head where to look at?

@liggitt
Copy link
Member

liggitt commented Aug 26, 2022

Check the master kubelet log… often that means an alpha feature broke the kubelet that runs the apiserver

@apelisse
Copy link
Member

Thanks for working on this!

@liggitt
Copy link
Member

liggitt commented Aug 26, 2022 •
edited

looks like the last green alpha e2e run was 8/23 (https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/111616/pull-kubernetes-e2e-gce-alpha-features/1562230740056281088) so something merged in the last ~3 days that broke that job

first red run on a PR that was previously green is https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/111333/pull-kubernetes-e2e-gce-alpha-features/1562457136405942272/

for bisecting purposes, that's:

good: 8887ac6

bad: 8674ce5

@liggitt
Copy link
Member

liggitt commented Aug 26, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
This was referenced Aug 26, 2022
Closed
Closed
@aojea
Copy link
Member Author

aojea commented Aug 26, 2022

/retest

@aojea
Copy link
Member Author

aojea commented Aug 27, 2022

Missing lgtm

@liggitt
Copy link
Member

liggitt commented Aug 27, 2022

/test pull-kubernetes-e2e-gce-alpha-features

@liggitt
Copy link
Member

liggitt commented Aug 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2022
@aojea
Copy link
Member Author

aojea commented Aug 27, 2022

/retest

Kubernetes e2e suite: [It] [sig-node] Pods should run through the lifecycle of Pods and PodStatus [Conformance] expand_more 1m9s

@k8s-ci-robot k8s-ci-robot merged commit 1959fe1 into kubernetes:master Aug 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 27, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @liggitt @apelisse @k8s-ci-robot @leilajal