Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Refactoring of Pod under pkg/api #112085

Merged
merged 4 commits into from Sep 26, 2022
Merged

Code Refactoring of Pod under pkg/api #112085

merged 4 commits into from Sep 26, 2022

Conversation

dipankardas011
Copy link
Contributor

  • added some function comments
  • spelling errors

Signed-off-by: Dipankar Das dipankardas0115@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Just adding what a function does and some minor refactoring

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dipankardas011
Code Refactoring
9eed137 
- added some function comments
- spelling errors

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dipankardas011. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 27, 2022
@dipankardas011
Some typo fix in resource under pkg/api/v1
6e29823 
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2022
@dipankardas011
Copy link
Contributor Author

dipankardas011 commented Sep 1, 2022 •
edited

Waiting for PR review🤞
@jayunit100 @tallclair

@leilajal
Copy link
Contributor

leilajal commented Sep 9, 2022

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@leilajal
Copy link
Contributor

leilajal commented Sep 9, 2022

/sig apimachinery

@k8s-ci-robot
Copy link
Contributor

@leilajal: The label(s) sig/apimachinery cannot be applied, because the repository doesn't have them.

In response to this:

/sig apimachinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leilajal
Copy link
Contributor

leilajal commented Sep 9, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2022
@dipankardas011
Copy link
Contributor Author

@leilajal not sure why the tests are failing 😕

@leilajal
Copy link
Contributor

/assign @DangerOnTheRanger
/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 13, 2022
@dipankardas011
Copy link
Contributor Author

Thanks for reviewing the pr @leilajal @DangerOnTheRanger 🙂

@dipankardas011
Copy link
Contributor Author

dipankardas011 commented Sep 16, 2022 •
edited

Is there anyone who can approve this PR

@DangerOnTheRanger
Copy link
Contributor

Sorry for the last-minute comment - feel free to /assign @liggitt for approval afterwards

@dipankardas011
Grammer corrections in api/v1/pod
d0b54a2 
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2022
@dipankardas011
Copy link
Contributor Author

/assign @liggitt

@dipankardas011 dipankardas011 requested review from DangerOnTheRanger and removed request for jayunit100 and tallclair September 17, 2022 03:48
liggitt
liggitt reviewed Sep 19, 2022
View reviewed changes
pkg/api/v1/pod/util.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Sep 19, 2022
View reviewed changes
pkg/api/v1/pod/util.go Outdated Show resolved Hide resolved
@dipankardas011
Copy link
Contributor Author

@liggitt could you check and merge it
Thanks 💯

@dipankardas011
Function description changes in pkg/api/v1
5df53a3 
- pod
- resource

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
@liggitt liggitt added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 26, 2022
@liggitt
Copy link
Member

liggitt commented Sep 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipankardas011, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 54ddcdc into kubernetes:master Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 26, 2022
@dipankardas011
Copy link
Contributor Author

Thanks @liggitt @DangerOnTheRanger @leilajal

@dipankardas011 dipankardas011 mentioned this pull request Jun 14, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@DangerOnTheRanger DangerOnTheRanger Awaiting requested review from DangerOnTheRanger

Assignees

@liggitt liggitt

@DangerOnTheRanger DangerOnTheRanger

@leilajal leilajal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dipankardas011 @k8s-ci-robot @leilajal @DangerOnTheRanger @liggitt