Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KMS] Disallow configuring multiple kms providers with the same name #112160

Closed
aramase opened this issue Aug 31, 2022 · 2 comments · Fixed by #113697
Closed

[KMS] Disallow configuring multiple kms providers with the same name #112160

aramase opened this issue Aug 31, 2022 · 2 comments · Fixed by #113697
Assignees
@aramase
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth Old

Comments

@aramase
Copy link
Member

aramase commented Aug 31, 2022

It is possible today to configure multiple kms providers with same name and different config (UDS, cache size, etc.). This does not provide any real value and would be a bug.

Open questions

Should we enforce a strict check to not allow this behavior? Any changes to this could be a breaking change.

/kind bug
/sig auth
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2022
@enj
Copy link
Member

enj commented Aug 31, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2022
@aramase aramase changed the title [KMS] Configuring multiple kms providers with the same name [KMS] Disallow configuring multiple kms providers with the same name Sep 9, 2022
@aramase
Copy link
Member Author

aramase commented Sep 9, 2022

/assign

@enj enj added this to Needs Triage in SIG Auth Old Sep 12, 2022
@aramase aramase mentioned this issue Oct 26, 2022
Closed
@aramase aramase mentioned this issue Nov 7, 2022
Merged
SIG Auth Old automation moved this from Needs Triage to Closed / Done Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aramase aramase

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
SIG Auth Old
Closed / Done
Milestone
No milestone
3 participants
@enj @aramase @k8s-ci-robot