Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for context cancellation on each buffered chunk #112476

Merged
merged 1 commit into from Sep 15, 2022
Merged

Check for context cancellation on each buffered chunk #112476

merged 1 commit into from Sep 15, 2022

Conversation

enj
Copy link
Member

@enj enj commented Sep 15, 2022

TestListPager_EachListItem flakes without this change.

Signed-off-by: Monis Khan mok@microsoft.com

/kind bug
/kind failing-test
/kind flake

NONE

Since y'all looked at #111241

/assign @liggitt @jpbetz @aojea

See https://storage.googleapis.com/k8s-triage/index.html?text=TestListPager_EachListItem and https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-unit/1568142167996633088 for example flakes.

@enj
Check for context cancellation on each buffered chunk
7458ed0 
TestListPager_EachListItem flakes without this change.

Signed-off-by: Monis Khan <mok@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 15, 2022
@enj
Copy link
Member Author

enj commented Sep 15, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 15, 2022
@enj
Copy link
Member Author

enj commented Sep 15, 2022

/retest

Pretty sure I did not cause this:

mkdir: cannot create directory '.make': Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
mkdir: cannot create directory '.make': Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
mkdir: cannot create directory '.make': Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
mkdir: cannot create directory '.make': Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
mkdir: cannot create directory '.make': Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
mkdir: cannot create directory '/home/prow/go/src/k8s.io/kubernetes/_output': Permission denied
!!! [0915 14:44:46] Call tree:
!!! [0915 14:44:46]  1: /home/prow/go/src/k8s.io/kubernetes/hack/lib/golang.sh:527 kube::golang::create_gopath_tree(...)
!!! [0915 14:44:46]  2: /home/prow/go/src/k8s.io/kubernetes/hack/lib/golang.sh:822 kube::golang::setup_env(...)
!!! [0915 14:44:46]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0915 14:44:46] Call tree:
!!! [0915 14:44:46]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
Makefile.generated_files:61: .make/go-pkgdeps.mk: No such file or directory
make[1]: *** [Makefile.generated_files:73: .make/go-pkgdeps.mk] Error 1
make: *** [Makefile:528: generated_files] Error 2

@enj
Copy link
Member Author

enj commented Sep 15, 2022

@liggitt updated.

@liggitt
Copy link
Member

liggitt commented Sep 15, 2022

unit test job just started running with a new securityContext which broke it:

      securityContext:
        allowPrivilegeEscalation: false
        runAsUser: 2000

@liggitt
Copy link
Member

liggitt commented Sep 15, 2022

commented at kubernetes/test-infra#27515 (comment)

@enj
Copy link
Member Author

enj commented Sep 15, 2022

/retest

1 similar comment
@enj
Copy link
Member Author

enj commented Sep 15, 2022

/retest

@aojea
Copy link
Member

aojea commented Sep 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@liggitt
Copy link
Member

liggitt commented Sep 15, 2022

/lgtm
/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit be506dc into kubernetes:master Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@aojea aojea aojea left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@sttts sttts Awaiting requested review from sttts

Assignees

@jpbetz jpbetz

@liggitt liggitt

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enj @liggitt @aojea @k8s-ci-robot @jpbetz