Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for runtime endpoint flag #112542

Merged
merged 1 commit into from Oct 1, 2022
Merged

Add validation for runtime endpoint flag #112542

merged 1 commit into from Oct 1, 2022

Conversation

astraw99
Copy link
Member

@astraw99 astraw99 commented Sep 17, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add validation to make the error msg more clearly, and also updated the CRI support error msg.

Which issue(s) this PR fixes:

Fixes #112541

Does this PR introduce a user-facing change?

Added validation for the --container-runtime-endpoint flag of kubelet to be non-empty.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 17, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2022
@astraw99 astraw99 force-pushed the fix-runtime-validate branch 2 times, most recently from cf8c578 to d070ffd Compare September 18, 2022 08:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2022
@astraw99 astraw99 mentioned this pull request Sep 22, 2022
Closed
@SergeyKanzhelev
Copy link
Member

/kind feature
/triage accepted

/release-note Added validation for the --container-runtime-endpoint flag of kubelet to be non-empty.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 22, 2022
@astraw99 astraw99 force-pushed the fix-runtime-validate branch 2 times, most recently from 495978a to 10bfa1f Compare September 23, 2022 12:41
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 23, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Approver in SIG Node PR Triage Sep 23, 2022
@astraw99
Copy link
Member Author

/assign @sjenning

@mrunalp mrunalp moved this from Needs Approver to Waiting on Author in SIG Node PR Triage Sep 27, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
SergeyKanzhelev
SergeyKanzhelev approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Sep 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astraw99, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0210941 into kubernetes:master Oct 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 1, 2022
@pacoxu pacoxu mentioned this pull request Oct 11, 2022
Merged
pacoxu added a commit to pacoxu/kubernetes that referenced this pull request Dec 13, 2022
@pacoxu
remove a flag check that was introduced in kubernetes#112542; address…
f28f40e 
… several comments

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@sjenning sjenning

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Got confusing errors when installing kubelet component
5 participants
@astraw99 @SergeyKanzhelev @k8s-ci-robot @mrunalp @sjenning